T7999: VPP add support iavf driver #4848
Conversation
|
👍 |
|
This driver has not been validated by our team |
c-po
left a comment
c-po
left a comment
There was a problem hiding this comment.
Add support for community tested only VPP drivers - but officially unsupported by VyOS
| driver: str = get_eth_driver(iface_name) | ||
|
|
||
| if driver_type == 'dpdk': | ||
| if driver in drivers_dpdk: |
There was a problem hiding this comment.
Driver iavf would not pass this check because it is not in drivers_dpdk. You should add it to drivers_dpdk list too
There was a problem hiding this comment.
I have done some refactoring of my PR
There was a problem hiding this comment.
Pull request overview
This PR adds support for the iavf driver (Intel Adaptive Virtual Function) in VPP, introducing a community driver mechanism that allows the use of drivers not officially tested by VyOS with explicit opt-in through a configuration flag.
Key Changes:
- Added
iavfto the list of community-supported DPDK drivers with warning mechanism - Introduced
allow-unsupported-nicsconfiguration option to enable community drivers - Enhanced driver verification logic to distinguish between officially supported and community drivers
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
python/vyos/vpp/config_verify.py |
Adds community_drivers_dpdk list and modifies verify_dev_driver() to return True for community drivers with warning |
src/conf_mode/vpp.py |
Imports community_drivers_dpdk and adds verification check requiring allow-unsupported-nics for community drivers |
interface-definitions/vpp.xml.in |
Adds new interfaces settings node with allow-unsupported-nics configuration option |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add support the iavf driver (virtual function)
|
CI integration ❌ failed! Details
|
3 participants
Change summary
Add support for the
iavfdriver (virtual function)Types of changes
Related Task(s)
Related PR(s)
How to test / Smoketest result
Checklist: